<?php $a = 2; ?>
<?= $this->partial("path/view", ["a" => 1]) ?>
<?= $a ?>Surprisingly that prints 1, instead of 2, is this a feature? or a bug?
The local variables in the views behaves like globals
This in php7.0 and phalcon 3.x
I think this is happening only in php 7 due to changes to symbol table.
Any solution other than preffixing the variables with the view name?
It adds a lot of work to name variables like $path_view_a.
Why zephir is not executing the require as php does? (in the context of the method)
https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/view/engine/php.zep#L56
I am not sure if this is a bug in zephir or a "new feature"
This is not about require. This is about render:
https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/view.zep#L845
As i told you, symbol tables where changed on php 7. There must be changes done to zephir in order to support what you want to achieve in php 7. On php 5.6 your code will work correctly. If you want you can create issue on zephir about this.
As I told you, it is a problem in the scopes (or the stack)
See this page: https://docs.zephir-lang.com/en/latest/language.html#variable-scope
But https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/view/engine/php.zep#L49 is not setting them to the local scope.
2 possibles explanations: Zephir is setting locals as static locals or globals (because it is still referencing to the same value in memory, even if it is in a different function call.
Said this, this is a new not documented feature or a bug.
All of this, or require doesn't execute in the function scope and execute in a global scope.
So, if a team member can confirm that indeed this is a bug, and not a feature, the bug can be created
As i already told you. This is because of PHP 7 and zephir. On PHP 5 it works fine. Just this https://github.com/phalcon/cphalcon/blob/master/phalcon/mvc/view.zep#L1073 is broken for php 7 and is not working correctly. Anyway, i will check it to be sure in home. But latest i was talking with some team member this symbol tables changes and not yet changed properly zephir is creating issue like yours.
Well btw anyway variables names like $a is really bad :D
Yes, you are partially right. Like path and view are bad names for a directory name and view name. But in the example context , those names are excellent ;) (Anyway, this is bikeshedding, I guess you were trolling)
Yes, I get the idea, it is creating the table. But in the zephir documentation is written this should happen anyway
All variables declared are locally scoped to the method where they were declared
https://docs.zephir-lang.com/en/latest/language.html#variable-scope
or (the title refers to the local scope, but "current PHP symbol table", so aren't they the same?) https://docs.zephir-lang.com/en/latest/language.html#local-symbol-table
Yes - and it's working fine for php 5. But as i told you there were some changes in symbol table for php 7. Zephir is not updated for it yet, it needs some changes to work properly with this example of your - this is why it's not working. Check your code on php 5. It should be fine.
Hi there,
Has this been fixed yet ? It's quite an important problem...
Thank you
In the meantime, have a look at this temporary fix : https://github.com/phalcon/cphalcon/issues/12176#issuecomment-405168661
I agree, we should hire some c programmer with knowledge of php and zend engine to fix those issues.