afterSave model event fired before transaction commit

Question

afterSave model event fired before transaction commit

Ciprian Coman Jun '20

Created Jun '20	Last Reply Jul '20	Replies 1	Views 144	Votes 0

Ciprian Coman 2.7k

Jun '20

Is there a way to fire afterCreate and afterSave events only after the transaction is commited succesfully?

// Controller
$t = new TransactionManager()->get()->throwRollbackException(true);

try {
   ...
   $a->setTransaction($t);
   $b->setTransaction($t);

   if (!$a->save()) {
      $t->rollback();
   }

// here the events for afterCreate / afterSave for model a are
// fired even thought the transaction was not commited

   if (!$b->save()) {
      $t->rollback();
   }

   $t->rollback('stop the transaction to test model events');

   $t->commit();
}

catch (Exception $e) {
   var_dump('if rollback, code should each here without running any afterSave event');
}

// Model
public function afterSave() {
   var_dump('should run after the data exists in the database');
}

Dylan Anderson · Answer 1 · 2020-06-26T08:12:51-07:00

I've never used either, but I wonder if getDirtyState() or getOperationMade(), could be called to see if the operaton completed successfully? Also, I'm not sure if getUpdatedFields() changes if the save failed.

If none of those work, maybe try wrapping save() to set a flag?

public function save(){
    $this->saved = parent::save();
    return $this->saved;
}
...
public function afterSave(){
    if($this->saved){
        // do stuff
    }
}

Ciprian Coman · Answer 2 · 2020-06-27T09:45:15-07:00

Thanks for the suggestion. I ended up using the EventManager to trigger a function after the transaction commit.