beforeExecuteRoute not firing properly

Question

beforeExecuteRoute not firing properly

Erik Wiesenthal Sep '15

Created Sep '15	Last Reply Sep '15	Replies 1	Views 744	Votes 0

Erik Wiesenthal 23.6k

Sep '15

Hi all,

I'm triying to catch a beforeException when an action does not exists but it does fire before the beforeExecuteRoute that I have at the controller.

this is the code:

abstract class ControllerWeb extends Controller 
{
    public function beforeExecuteRoute(Dispatcher $dispatcher)
    {
          die("beforeExecuteRoute");
    }
}


class PagePlugin extends Plugin
{
    public function beforeException(Event $event, Dispatcher $dispatcher, \Exception $exception = null)
    { 
          die("beforeException");
    }

}

When I try to access to a non defined action I want my beforeException to fire, but AFTER the beforeExecuteRoute The beforeExecuteRoute fires properly on other cases, but when the Action is not defined the beforeException fires first. Is this the normal behaviour? As I see it the beforeExecuteRoute must fire first since we don't care yet about the action or controller exceptions, right?

Erik Wiesenthal · Answer 1 · 2015-09-28T04:32:41-07:00

I see:

beforeExecuteRoute: Triggered before executing the controller/action method. At this point the dispatcher has been initialized the controller and know if the action exist.

it does fire the exception first :(

Lajos Bencz · Answer 2 · 2015-09-29T05:18:51-07:00

Use beforeException:

class NotFound extends Plugin {

    /**
     * This action is executed before execute any action in the application
     *
     * @param Event $event
     * @param MvcDispatcher $dispatcher
     * @param Exception $exception
     * @return bool
     */
    public function beforeException(Event $event, MvcDispatcher $dispatcher, Exception $exception)
    {
        if ($exception instanceof DispatcherException) {
            switch ($exception->getCode()) {
                case Dispatcher::EXCEPTION_HANDLER_NOT_FOUND:
                case Dispatcher::EXCEPTION_ACTION_NOT_FOUND:
                    $dispatcher->forward(array(
                        'controller' => 'error',
                        'action' => 'show404'
                    ));
                    return false;
            }
        }
        /*
        if($this->config->application->debug) {
            return true;
        }
        */
        $dispatcher->forward(array(
            'controller'=> 'error',
            'action'    => 'show500',
            'params'    => [$exception],
        ));
        return false;
    }

}

/// services.php
        $eventsManager->attach('dispatch:beforeException', new NotFoundPlugin);
        $dispatcher->setEventsManager($eventsManager);